-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to build without distutils #98
Allow to build without distutils #98
Conversation
Is this ready to be reviewed? I held off since it was still marked as "Draft". (I suppose same for modelon-community/PyFMI#236) |
yes, this is ready: the skbuild/cmake path is not good enough because it does not allow to fully cross-compile the windows fortran modules with the 2 different compiler/linkers needed (msvc+msys/gfortran) like its currently done in conda-forge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good here too, just a minor comment, and add a changelog entry, thanks again!
done |
hello @PeterMeisrimelModelon @modelonrobinandersson could we tag a new version with this ? |
hi @jschueller I will get back tomorrow, I am just going to make a minor test on my end with these changes and then I hope to merge it. |
6ea28a4
into
modelon-community:master
* Allow to build without distutils * Drop svn version log
No description provided.